PORT-8146 filter events without diff in port #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RT-8146-filter-events-without-diff
talsabagport
requested changes
May 16, 2024
pkg/k8s/controller.go
Outdated
|
|
||
| if updateEntityOnlyOnDiff == false { | ||
| return true | ||
| } else { |
pkg/k8s/controller_test.go
Outdated
| @@ -317,3 +347,76 @@ func TestGetEntitiesSet(t *testing.T) { | |||
| f := newFixture(t, "", "", "", resource, objects) | |||
| f.runControllerGetEntitiesSet(expectedEntitiesSet, false) | |||
| } | |||
|
|
|||
| func TestUpdateDeploymentWithoutDiff(t *testing.T) { | |||
pkg/k8s/controller_test.go
Outdated
| assert.True(t, result, "Expected true when different object and feature flag is off") | ||
|
|
||
| controllerWithPartialMapping := newFixture(t, "", "", "", partialMappingWithoutLables, []runtime.Object{}).controller | ||
| result = controllerWithPartialMapping.shouldSendUpdateEvent(oldDeployment, newDep, true) |
There was a problem hiding this comment.
Add with feature flag false
pkg/k8s/controller.go
Outdated
| klog.Errorf("Error getting new entities: %v", err) | ||
| return true | ||
| } | ||
| oldEntitiesHash, err := hashAllEntities(oldEntities) |
There was a problem hiding this comment.
Consider adding tests to hash various entities
pkg/k8s/controller.go
Outdated
| return true | ||
| } | ||
|
|
||
| if oldEntitiesHash != newEntitiesHash { |
There was a problem hiding this comment.
Do the opposite - return false if they equal, and return true below
talsabagport
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uests using hash
Description
What -
Why -
How -
Type of change
Please leave one option from the following and delete the rest: