PORT-10327 Bug | Cannot update certain fields from Github Action #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed logMessage and status validation - Added workflow to test
PeyGis
reviewed
Oct 8, 2024
| @@ -1,12 +1,12 @@ | |||
| { | |||
| "name": "port-github-action", | |||
| "version": "1.1.0", | |||
| "version": "1.1.1", | |||
There was a problem hiding this comment.
Since we've bumped the version, we may need to verify if the development-team will need to adjust anything at their end in order to benefit from this bugfix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Extended the update operation to allow updating any of the fields (statusLabel, logMessage, link, etc.) based on API requirements, rather than limiting updates to status or logMessage only.
Why - There was a bug preventing the update of fields like statusLabel and link. The system previously only supported updating either the status or the log message.
How - Modified the parseInput method to allow updating any field from the API, removed the validation that required status or logMessage, and added support for partial updates. Updated the workflow for testing the changes.
Type of change
Please leave one option from the following and delete the rest: