-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][Gitlab] Bug | Gitlab integration doesnt perform Glob queries properly #1309
Open
shariff-6
wants to merge
16
commits into
main
Choose a base branch
from
PORT-11280-Bug-Gitlab-integration-doesnt-perform-Glob-queries-properly
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Integration][Gitlab] Bug | Gitlab integration doesnt perform Glob queries properly #1309
shariff-6
wants to merge
16
commits into
main
from
PORT-11280-Bug-Gitlab-integration-doesnt-perform-Glob-queries-properly
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shariff-6
changed the title
[Bug][Gitlab] | Gitlab integration doesnt perform Glob queries properly
[Integration][Gitlab] Bug | Gitlab integration doesnt perform Glob queries properly
Jan 8, 2025
…tching Removes custom pattern matching in search_files_in_project in favor of GitLab's native path: search capability. This change: - Removes redundant pattern filtering using does_pattern_apply - Uses GitLab's search API path parameter directly - Updates tests to reflect GitLab's actual search behavior
…1280-Bug-Gitlab-integration-doesnt-perform-Glob-queries-properly
- Replace custom pattern matching implementation with glob2.fnmatch
Refactored GitLab file search to: - Add braceexpand pattern conversion - Update search function to use converted patterns - Consolidate search tests into parameterized test - Remove redundant test cases
…1280-Bug-Gitlab-integration-doesnt-perform-Glob-queries-properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
Why
How
_match
function to handle"**"
more effectively, allowing for emptystring_parts
.Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.