Skip to content

Commit

Permalink
Fixed spaces in identifiers (#616)
Browse files Browse the repository at this point in the history
# Description

What - Fixed case where identfiers can have a space
Why - IngestionErrors for these kind of identifiers
How - Added regex to remove spaces

## Type of change

Please leave one option from the following and delete the rest:

- [ ] Bug fix (non-breaking change which fixes an issue)

## Screenshots


![image](https://github.com/port-labs/ocean/assets/51418643/54dda73c-cd26-4cdd-8f4c-ec6cece45038)

## API Documentation

[Provide links to the API documentation used for this
integration.](https://docs.getport.io/build-your-software-catalog/sync-data-to-catalog/git/azure-devops/)
  • Loading branch information
matan84 authored May 8, 2024
1 parent c6af802 commit e950c4a
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ resources:
port:
entity:
mappings:
identifier: '.id'
identifier: '.id | gsub(" "; "")'
blueprint: '"project"'
title: .name
properties:
Expand All @@ -24,7 +24,7 @@ resources:
port:
entity:
mappings:
identifier: '.project.name + "/" + .name'
identifier: '.project.name + "/" + .name | gsub(" "; "")'
blueprint: '"service"'
title: .name
properties:
Expand All @@ -39,7 +39,7 @@ resources:
port:
entity:
mappings:
identifier: '.__repository.project.name + "/" + .__repository.name'
identifier: '.__repository.project.name + "/" + .__repository.name | gsub(" "; "")'
blueprint: '"service"'
properties:
minimumApproverCount: '.settings.minimumApproverCount'
Expand All @@ -50,7 +50,7 @@ resources:
port:
entity:
mappings:
identifier: '.__repository.project.name + "/" + .__repository.name'
identifier: '.__repository.project.name + "/" + .__repository.name | gsub(" "; "")'
blueprint: '"service"'
properties:
workItemLinking: '.isEnabled and .isBlocking'
7 changes: 7 additions & 0 deletions integrations/azure-devops/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- towncrier release notes start -->

# Port_Ocean 0.1.19 (2024-05-08)

### Improvements

- Removed spaces from service identifier field (#1)


# Port_Ocean 0.1.18 (2024-05-08)

### Improvements
Expand Down
2 changes: 1 addition & 1 deletion integrations/azure-devops/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "azure-devops"
version = "0.1.18"
version = "0.1.19"
description = "An Azure Devops Ocean integration"
authors = ["Matan Geva <[email protected]>"]

Expand Down

0 comments on commit e950c4a

Please sign in to comment.