Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean lowercase installation resync job name #130

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Ocean lowercase installation resync job name #130

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95d52d6
change the job name to lowercase for ocean cron installation
yairsimantov20 Jul 10, 2024
418ac59
support suspending the cron
yairsimantov20 Jul 10, 2024
46e531b
bump
yairsimantov20 Jul 10, 2024
8a430a8
change the job name to lowercase for ocean cron installation
yairsimantov20 Jul 10, 2024
1a64c6d
support suspending the cron
yairsimantov20 Jul 10, 2024
ae5291c
bump
yairsimantov20 Jul 10, 2024
615998b
Merge remote-tracking branch 'origin/ocean-lowercase-installation-res…
yairsimantov20 Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion charts/port-ocean/templates/cron-job/cron.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ metadata:
spec:
failedJobsHistoryLimit: 5
successfulJobsHistoryLimit: 1
schedule: {{ required "scheduledResyncInterval is required when using CronJob workload kind" .Values.scheduledResyncInterval | quote }}
schedule: {{ .Values.scheduledResyncInterval | default "0 */1 * * *" }}
suspend: {{ or .Values.workload.cron.suspend (eq .Values.scheduledResyncInterval "")}}
concurrencyPolicy: Replace
jobTemplate:
metadata:
Expand Down
2 changes: 1 addition & 1 deletion charts/port-ocean/templates/cron-job/installation-resync-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{{- $resyncOnInstall := (.Values.workload.cron).resyncOnInstall | default true }}
{{- $resyncOnUpgrade := (.Values.workload.cron).resyncOnUpgrade | default true }}
{{- if and (eq .Values.workload.kind "CronJob") (or $resyncOnInstall $resyncOnUpgrade) }}
{{- $jobName := print (randAlphaNum 4) "-" .Release.Revision }}
{{- $jobName := (print (randAlphaNum 4) "-" .Release.Revision) | lower }}
apiVersion: batch/v1
kind: Job
metadata:
Expand Down
1 change: 1 addition & 0 deletions charts/port-ocean/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ workload:
resyncTimeoutMinutes: null
resyncOnInstall: true
resyncOnUpgrade: true
suspend: false

resources:
requests:
Expand Down
Loading