Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add pod annotations to port-ocean deployment #112

Merged

Conversation

gomgomshrimp
Copy link
Contributor

Description

What - podAnnotations is missing in deployment.yaml
Why - podAnnotations is defined value.yaml, but not applied to deployment.yaml.
How - Add podAnnotations to deployment.yaml

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution @gomgomshrimp 🙏
please make sure to bump the chart version

@gomgomshrimp
Copy link
Contributor Author

@Tankilevitch
Thank you, I've bumped the port-ocean chart.

Copy link
Contributor

@yairsimantov20 yairsimantov20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊

@yairsimantov20 yairsimantov20 merged commit 07839f5 into port-labs:main Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants