Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what sort of intervals contig.add_dfe expects #1580

Closed
nspope opened this issue Jul 26, 2024 · 1 comment
Closed

Document what sort of intervals contig.add_dfe expects #1580

nspope opened this issue Jul 26, 2024 · 1 comment
Assignees
Milestone

Comments

@nspope
Copy link
Collaborator

nspope commented Jul 26, 2024

In the docs https://popsim-consortium.github.io/stdpopsim-docs/stable/api.html#stdpopsim.Contig.add_dfe I think we should make it extra clear what sort of interval is expected; e.g. 0-based coordinate system and inclusive endpoint (I think that's the case based on the current text but am not entirely sure?)

@nspope nspope self-assigned this Dec 20, 2024
@nspope nspope added this to the Version 0.2.1 milestone Dec 20, 2024
@petrelharp
Copy link
Contributor

It's zero-based and left-closed-right-open:

            # stdpopsim intervals are 0-based left inclusive, right exclusive, but
            # SLiM intervals are right inclusive

petrelharp added a commit to petrelharp/stdpopsim that referenced this issue Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants