Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC for DomesticusEurope_1F22, MusculusKorea_1F22, and CastaneusIndia_1F22 (MusMus) #1528

Closed
igronau opened this issue Oct 17, 2023 · 2 comments
Labels
Model QC Quality control process for model addition

Comments

@igronau
Copy link
Contributor

igronau commented Oct 17, 2023

PR for new model: #1485
Original paper: Fujiwara et al. 2022
Parameter values: Fig 3 - sent by authors to @peterdfields
Population indices: three separate 1-pop models

Potential issues that might lead to differences between the model implementations:
NA

QC'er requests: I manually inspected model already. Now, I just have to write the QC code.

@igronau igronau added the Model QC Quality control process for model addition label Oct 17, 2023
@igronau
Copy link
Contributor Author

igronau commented Oct 18, 2023

I implemented the QC tests for the three demographic models. See PR #1531 I ran the tests locally and they pass. It'll be good if someone can have another look before this is merged (@petrelharp :-)).

@nspope
Copy link
Collaborator

nspope commented Jul 6, 2024

Closing as the QC is merged

@nspope nspope closed this as completed Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Model QC Quality control process for model addition
Projects
None yet
Development

No branches or pull requests

2 participants