Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sync slideshow toggle with cosmic-bg #236

Merged

Conversation

joshuamegnauth54
Copy link
Contributor

Closes: #169

Copy link
Member

@mmstick mmstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be out of sync with cosmic-bg. It already gets slideshow state from cosmic-bg's config. The slideshow feature is enabled when the background is a path.

@joshuamegnauth54 joshuamegnauth54 force-pushed the wallpaper-slideshow-toggle-fix branch from 6b22b34 to 317a1bf Compare April 12, 2024 03:58
@joshuamegnauth54
Copy link
Contributor Author

Good point. I updated the code to get the slideshow status from cosmic-bg.

The final code is much simpler than my first attempt.

@joshuamegnauth54 joshuamegnauth54 changed the title fix: Add config entry for slideshow fix: Sync slideshow toggle with cosmic-bg Apr 12, 2024
@mmstick mmstick merged commit 051bce2 into pop-os:master Apr 12, 2024
3 checks passed
@mmstick
Copy link
Member

mmstick commented Apr 12, 2024

Thanks!

@joshuamegnauth54 joshuamegnauth54 deleted the wallpaper-slideshow-toggle-fix branch April 26, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallpaper > Slideshow toggle changes to off after being enabled
2 participants