fix(domains): use correct domain when uploading files #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 0.12.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue raised last week about receiving 405 responses for the server: https://3.basecamp.com/4298486/buckets/20761313/todos/7919458279
For a reason I am not entirely clear on, the redirect function was not redirecting the file upload requests properly. I think we have accepted that the redirect function from .cloud to .solutions is not going to work reliably for API calls and therefore where possible it is safer to simply change the hardcoded references from .cloud to .solutions.
This is what this PR does and I can confirm that it works as expected. This is also safe to release to production because the .solutions domains are ready to roll 😀