AssetHub: Fee payment with any sufficient asset #11229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
reviewed
Feb 3, 2025
TarikGul
reviewed
Feb 4, 2025
TarikGul
reviewed
Feb 4, 2025
TarikGul
requested changes
Feb 4, 2025
There was a problem hiding this comment.
I think we can better optimize the way we handle chains that support using assetId's. Even if the support only extends to assset-hub (statemine, statemint) we can better improve our workflow here.
The best approach IMO is to see if the necessary assets pallet exists (there might be some additional checks we can make to ensure we can pay with assets for fees) - check what the palletIndex is (for inputting in the multilocation) - and then from there offer support for paying with assets for fees.
Kailai-Wang
pushed a commit
to litentry/polkadot-js-apps
that referenced
this pull request
Feb 6, 2025
* feat: created useAssetIds and useAssetInfo hook * feat: created pay with asset component * feat: add paywith asset component with Transfer modal * fix: signer options as prop * fix: payment info * feat: created PayWithAsset provider and integrated with transfer form * chore: rename variable * fix: PayWithAsset provider wrapping * feat: integrate PayWithAsset context and enhance asset info fetching * fix: some build errors * refactor: update imports and simplify getFeeAssetLocation function * refactor: simplify component structure and update PayWithAsset import paths * fix: all build errors * fix: avoid redundant type * feat: added translation * feat: enhance fee payment info & fee asset handling * fix: translations ordering * fix: remove redundant types and hooks * chore: added statemine chain * refactor: generalize fee acceptance check for non-native assets * fix: remove constants and generalize palletIndex
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR introduces the ability to select an asset for paying fees. For example, Asset Hub allows fees to be paid in sufficient assets like USDt and USDC. Initially, this feature will be implemented for the Balance Transfer component, with plans to extend it across other relevant pages/components in the future.
Screen.Recording.2025-02-03.at.16.11.19.mov
✅ Tasks
PayWithAssetcomponent which allow users to choose asset to pay fee