-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RFC mdBook web page #60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, im sure there will be future iteration :)
Is this the final URL https://paritytech.github.io/RFCs/ ? |
The final URL is: https://polkadot-fellows.github.io/RFCs/ The paritytech one has served as a preview, before it was configured in polkadot-fellows. |
Thanks! @wirednkod we can probably also integrate this into the official website i hope. |
We already have this: https://polkadot-fellows.github.io/dashboard/#/rfcs that shows all the open RFCs. I am thinking that probably we can create either a link to "more details" from the official website, or merge the 2 and build the "cargo book" and then release it with the site. The only thing I can see as a "problem" (not really one but to the eyes of a front-end dev it could be) - is the theme and design incosistency, but that could be fixed I guess. |
Hey @wirednkod, I didn't know about this dashboard 👍
Do you have an idea on how we could do it in details? I see that the dashboard is fetching the PRs dynamically from Github. What if it fetched the RFC data from the mdBook Github branch instead? The branch is That way, the dashboard would operate on the same raw data, but present it with its own front-end design. Unless we want to simply go with a link and keep only one site with full details - that seems reasonable too. |
@rzadp mdBook is nothing more than generated This way the I would like to suggest some changes to what you have if we agreed to go with the aforrementioned direction:
I can add those as issues at https://github.com/polkadot-fellows/RFCs/ |
Sounds good, I agree with you.
Makes total sense, no need to create an issue, I will do it right away.
It doesn't seem right for me, for a user who stumbles upon this link to not have any kind of description of what he's looking at. Are you sure about it? If the problem is that it's too short (a single sentence at the moment), we could add more to it. |
Yeah - now that I rethink it - it does make sense for it to exist. So we are good. |
@rzadp I have integrated now the RFC-book inside the dashboard (see sceenshot): |
Reorder RFCs in the mdBook as suggested [here](#60 (comment)). cc @wirednkod
What it does
gh-pages
branch - to be published in Github Pages.main
, and periodically once a day.