Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowering Deposit Requirements on Polkadot and Kusama Asset Hub #45
Lowering Deposit Requirements on Polkadot and Kusama Asset Hub #45
Changes from all commits
d3f3e16
4c90e8e
a1c6854
316cd45
7d5e9c3
0a217aa
4ba607f
d40dffd
6d297fb
0e49a4f
3b48582
cef02e1
88c0f69
cfc84ed
a15b1bd
edf6758
4079c29
e9a81d4
28e217a
9541841
5b34f67
4237d37
a3d3cb1
731d0c1
d16fa29
c464459
17b5448
3328781
33194da
23b9bab
c6e9970
f519da0
f4fa857
a8dcdf2
3ad68dd
759c140
823013e
0bb0f60
a7319f0
c7edfc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is more than one storage item, so to be really precise it should be something in the form of
system_para_deposit(1, x) + system_para_deposit(1, y)
(Collection
andCollectionRoleOf
) but i dont want to block this RFC much longer.Guess this approximates it well enough for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there are two items then we should probably be consistent. It should still be a large reduction (from 10 to 0.4 instead of 0.2).
Broadly speaking though, and w/r/t the idea of finding an "optimal" deposit, it can never be perfect. As long as you can't start adding more storage items for free (i.e. deposit is directly proportional to storage items added) then it's well-designed. Factors of 2x are just not significant (and it's a bit arrogant to think we can get it so precise). I think probably 10x is the best we can hope for with these parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have monitoring in place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @KarimJedda or someone from KodaDot is tracking NFT activity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @vikiival is in a good position to answer this question, since he created indexer for AssetHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top 3 creators on AHP
Data are public via our @subsquid indexer or Typescript API (kodadot/uniquery)