Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFCs Web Page [mdbook] #53

Closed
mordamax opened this issue Nov 23, 2023 · 7 comments · Fixed by #60
Closed

RFCs Web Page [mdbook] #53

mordamax opened this issue Nov 23, 2023 · 7 comments · Fixed by #60

Comments

@mordamax
Copy link

@PierreBesson suggested rendering our polkadot-fellows/RFCs as a webpage - similar to https://eips.ethereum.org/

Tracked in paritytech/eng-automation#1

@rzadp
Copy link
Contributor

rzadp commented Dec 1, 2023

I have created the mdbook and I'm looking for feedback.

The book can be previewed here.

Calling thumb-uppers: @xlc @lrazovic @davxy @bkchr

@xlc
Copy link
Contributor

xlc commented Dec 4, 2023

I can't say I enjoy the font and colour scheme (mostly the slime green) but otherwise looks good
Screenshot 2023-12-04 at 1 08 58 PM

@shawntabrizi
Copy link
Member

I agree, I don't think there is any need for aggressive styling.

@davxy
Copy link
Contributor

davxy commented Dec 4, 2023

Some personal opinions:

  • I prefer a simple monospaced font and with less colors around. Something more close to the IETF RFCs (EIP are quite good).
  • Is possible to auto generate a TOC at the begin for easy navigation? Should be. We can limit TOC depth to maybe 1 or 2 or even 3 (but not 4)
  • A table like this would be nice for exploration. We also should start think about categories or tags. A good place to add category and tags can be the header https://github.com/polkadot-fellows/RFCs/blob/main/0000-template.md

@lrazovic
Copy link

lrazovic commented Dec 4, 2023

Very well done!

I agree with the feedback provided earlier. I appreciate the concept of a 'Polkadot' theme aligned with the brand identity (https://polkadot.network/ecosystem/brand-hub/), but considering the nature of the site's content, perhaps prioritizing readability in the default theme would be more beneficial. The 'Polkadot' theme could then be offered as an alternative option.

@rzadp
Copy link
Contributor

rzadp commented Dec 5, 2023

Thanks for the feedback. :)

Update

  • I have toned down the Polkadot branded theme.
  • I'm generating TOCs.
  • I've separated proposed RFCs into "new", "stale", and the rest
    • Currently "new" means PRs created in the last 7 days, and "stale" means PRs not updated for at least 30 days.

Please take another look.

@rzadp
Copy link
Contributor

rzadp commented Dec 5, 2023

We also should start think about categories or tags. A good place to add category and tags can be the header https://github.com/polkadot-fellows/RFCs/blob/main/0000-template.md

@davxy The problem with categories/tags in the header is that it cannot be applied for the RFCs that are already merged - the exact hash of the text is on-chain so the text shouldn't be changed after merging.

And even if we're only looking at new RFCs, the problem will be that we won't be able to re-categorize / re-tag them in the future (for the same reason).

How about using github labels for this purpose? Already-merged PRs can be re-labeled.

@bkchr bkchr closed this as completed in #60 Jan 3, 2024
bkchr pushed a commit that referenced this issue Jan 3, 2024
- Closes #53
- Preview available [here](https://paritytech.github.io/RFCs/).

![Screenshot 2023-12-19 at 13 55
05](https://github.com/polkadot-fellows/RFCs/assets/12039224/ee06a7ad-231e-4077-a773-c6319661dfb6)


---

### What it does

- The workflow gathers the source markdown files of RFCs - approved
ones, and proposed ones (from open PRs).
- The proposed RFCs are separated into new (<7 days since PR created)
and stale (>30 days since PR updated).
- The RFCs are extended with a table of contents, and a link to the
source.
- The RFCs are build into a web page using
[mdBook](https://github.com/rust-lang/mdBook).
- The built web page gets pushed to `gh-pages` branch - to be published
in Github Pages.
- The workflow is triggered on merge to `main`, and periodically once a
day.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants