-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFCs Web Page [mdbook] #53
Comments
I agree, I don't think there is any need for aggressive styling. |
Some personal opinions:
|
Very well done! I agree with the feedback provided earlier. I appreciate the concept of a 'Polkadot' theme aligned with the brand identity (https://polkadot.network/ecosystem/brand-hub/), but considering the nature of the site's content, perhaps prioritizing readability in the default theme would be more beneficial. The 'Polkadot' theme could then be offered as an alternative option. |
Thanks for the feedback. :) Update
Please take another look. |
@davxy The problem with categories/tags in the header is that it cannot be applied for the RFCs that are already merged - the exact hash of the text is on-chain so the text shouldn't be changed after merging. And even if we're only looking at new RFCs, the problem will be that we won't be able to re-categorize / re-tag them in the future (for the same reason). How about using github labels for this purpose? Already-merged PRs can be re-labeled. |
- Closes #53 - Preview available [here](https://paritytech.github.io/RFCs/). ![Screenshot 2023-12-19 at 13 55 05](https://github.com/polkadot-fellows/RFCs/assets/12039224/ee06a7ad-231e-4077-a773-c6319661dfb6) --- ### What it does - The workflow gathers the source markdown files of RFCs - approved ones, and proposed ones (from open PRs). - The proposed RFCs are separated into new (<7 days since PR created) and stale (>30 days since PR updated). - The RFCs are extended with a table of contents, and a link to the source. - The RFCs are build into a web page using [mdBook](https://github.com/rust-lang/mdBook). - The built web page gets pushed to `gh-pages` branch - to be published in Github Pages. - The workflow is triggered on merge to `main`, and periodically once a day.
@PierreBesson suggested rendering our polkadot-fellows/RFCs as a webpage - similar to https://eips.ethereum.org/
Tracked in paritytech/eng-automation#1
The text was updated successfully, but these errors were encountered: