Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Polkadot Wiki Migration] Using Systemd #46

Merged
merged 8 commits into from
Oct 8, 2024
Merged

[Polkadot Wiki Migration] Using Systemd #46

merged 8 commits into from
Oct 8, 2024

Conversation

CrackTheCode016
Copy link
Collaborator

@CrackTheCode016 CrackTheCode016 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 20, 2024
@dawnkelly09
Copy link
Collaborator

Quick scan for Vale calibration and removed some line breaks and spacing issues

@CrackTheCode016 @0xLucca @nhussein11
Apply suggestions from code review
c0ffc8d 
Co-authored-by: 0xLucca <[email protected]>
Co-authored-by: Nicolás Hussein <[email protected]>
CrackTheCode016
CrackTheCode016 commented Oct 1, 2024
View reviewed changes
infrastructure/validators/onboarding/run-validator/index.md
@@ -0,0 +1,7 @@
---
title: Run a Validator
description: TODO
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, in secure a node (PR #47), I have put a description.

lovelaced
lovelaced reviewed Oct 2, 2024
View reviewed changes
infrastructure/validators/onboarding/run-validator/using-systemd.md Outdated
touch /etc/systemd/system/polkadot-validator.service
```

In this unit file you will write the commands that you want to run on server boot / restart.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to use the systemd file from the repo: https://github.com/paritytech/polkadot-sdk/blob/master/polkadot/scripts/packaging/polkadot.service

this is also included in the .deb package when installing it through apt or similar

@eshaben eshaben requested a review from a team as a code owner October 4, 2024 21:07
@eshaben
Copy link
Collaborator

eshaben commented Oct 4, 2024

@CrackTheCode016 I added a prereqs section with more specific items, let me know what ya think!

@CrackTheCode016
Copy link
Collaborator Author

@eshaben yep, lgtm

@eshaben eshaben requested a review from dawnkelly09 October 8, 2024 04:40
dawnkelly09
dawnkelly09 approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

0xLucca
0xLucca approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xLucca 0xLucca merged commit cb4d953 into master Oct 8, 2024
@0xLucca 0xLucca deleted the bd-infra-systemd branch October 8, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovelaced lovelaced lovelaced left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

@0xLucca 0xLucca 0xLucca approved these changes

@nhussein11 nhussein11 Awaiting requested review from nhussein11

@eshaben eshaben Awaiting requested review from eshaben

Assignees
No one assigned
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CrackTheCode016 @dawnkelly09 @eshaben @lovelaced @nhussein11 @0xLucca