Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Polkadot Wiki Migration] Upgrade Your Node #36

Merged
merged 10 commits into from
Oct 21, 2024
Merged

[Polkadot Wiki Migration] Upgrade Your Node #36

merged 10 commits into from
Oct 21, 2024

Conversation

CrackTheCode016
Copy link
Collaborator

github-actions[bot]
github-actions bot reviewed Sep 17, 2024
View reviewed changes
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
@dawnkelly09
Copy link
Collaborator

Scan for Vale false positives. Resolved convos = made it on the update list and should go away now. I left comments for the legit flags with suggested edits. Thank you!

@CrackTheCode016 CrackTheCode016 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 20, 2024
@nhussein11 nhussein11 self-requested a review September 27, 2024 11:33
dawnkelly09
dawnkelly09 requested changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some formatting/grammar edits and moved terminal to snippets, etc.
@polkadot-developers/docs-content-team please see my comments on content needs --- make sure you check out the snippet for the terminal output because it is missing the command. Please request new format review after updates. Thanks!

infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated

## Steps

The following steps require a second validator which will be referred to as `Validator B`. The
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be a quick overview of which steps are needed with a more extensive tutorial somewhere else? If there isn't a more detailed tutorial to go with this, then some of these steps should have more detail. What commands do I use to start a second node? How do I generate session keys? etc. This section has a nice amount of "what" but almost no "how"

Copy link
Collaborator

@eshaben eshaben Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are steps they most likely (if not, someone on their team) would have already gone through when setting up the original validator.

I would just add a link to the onboarding page, which will include how to get a node up and running and how to generate session keys

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another note: I think this page will get heavily updated at some point, so I would link to other places for now where needed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I linked the "How to Validate" page, which covers this as a prerequisite. We can definitely make it flow a little better, though.

infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated
**Validator B** is now acting as your validator - you can safely perform operations on **Validator
A**.

When you are ready to restore **Validator A**:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above. Do we need more how in here or will there be tutorial(s) to link out to?

infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated Show resolved Hide resolved
@0xLucca
Copy link
Collaborator

0xLucca commented Oct 7, 2024

Hey @CrackTheCode016,

I'd like to clarify the objective of this section. The current process seems to involve:

  1. Spinning up an additional validator (B)
  2. Applying fixes and upgrades to the original validator (A)
  3. Restarting validator A

Wouldn't it be more efficient to apply all changes to the server of validator B before starting it? This reduces the process time from (N+3) * 2 sessions to N+3 sessions

Could you please elaborate on the rationale behind the current method? Maybe there are specific advantages to this approach that I might be overlooking

@CrackTheCode016 CrackTheCode016 requested a review from a team as a code owner October 15, 2024 21:32
@CrackTheCode016
Copy link
Collaborator Author

@0xLucca This appears to me like it would work, I'll ping infra and get a final answer before making any changes.

@BulatSaif
Copy link

Good to go! I like that you emphasized the importance of waiting for 2 full sessions—it’s really important.

@eshaben eshaben requested a review from dawnkelly09 October 17, 2024 02:41
eshaben
eshaben reviewed Oct 17, 2024
View reviewed changes
infrastructure/validators/operational-tasks/how-to-upgrade-validator.md Outdated

!!! warning

It is imperative you keep `Validator A` running during this time. `set_key` doesn't have an immediate effect and requires two full sessions to elapse before it does. If you switch off `Validator A` too early you may risk being chilled and face a fault within the Thousand Validator Programme.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thousand Validators still kicking?

Copy link
Collaborator

@0xLucca 0xLucca Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is being replaced by the Decentralized Nodes program:
https://nodes.web3.foundation/

eshaben
eshaben approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xLucca
Copy link
Collaborator

0xLucca commented Oct 21, 2024

@dawnkelly09 This is ready to merge, just needs your approval

dawnkelly09
dawnkelly09 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@dawnkelly09 dawnkelly09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@eshaben eshaben merged commit 37a14e6 into master Oct 21, 2024
@eshaben eshaben deleted the bd-infra-upgrade-validator branch October 21, 2024 16:13
kapetan3sid pushed a commit that referenced this pull request Nov 8, 2024
@CrackTheCode016 @dawnkelly09
@nhussein11 @eshaben @kapetan3sid
[Polkadot Wiki Migration] Upgrade Your Node (#36)
335e908 
* add initial page

* title

* some stuff

* Apply suggestions from code review

Co-authored-by: Dawn Kelly <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nicolás Hussein <[email protected]>

* first pass of edits, still WIP

* moves terminal output to styled element in snippet

* Fix line breaks

* Add prerequisites

---------

Co-authored-by: Dawn Kelly <[email protected]>
Co-authored-by: Nicolás Hussein <[email protected]>
Co-authored-by: DAWN KELLY <[email protected]>
Co-authored-by: Erin Shaben <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@nhussein11 nhussein11 nhussein11 left review comments

@0xLucca 0xLucca 0xLucca approved these changes

@BulatSaif BulatSaif BulatSaif approved these changes

@eshaben eshaben eshaben approved these changes

@dawnkelly09 dawnkelly09 dawnkelly09 approved these changes

Assignees
No one assigned
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CrackTheCode016 @dawnkelly09 @0xLucca @BulatSaif @eshaben @nhussein11