Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protocol/architecture updates use of admos for all pages in section #329

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dawnkelly09
Copy link
Collaborator

Updates the usage of admonitions on the pages in the protocol/architecture section. There are also some grammar things from putting pages I edited through Grammarly.

@dawnkelly09 dawnkelly09 requested a review from a team as a code owner January 27, 2025 19:22
@dawnkelly09 dawnkelly09 added A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B0 - Needs Review Pull request is ready for review labels Jan 27, 2025
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

polkadot-protocol/architecture/parachains/overview.md Outdated Show resolved Hide resolved
polkadot-protocol/architecture/parachains/overview.md Outdated Show resolved Hide resolved
polkadot-protocol/architecture/system-chains/bridge-hub.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dawnkelly09 dawnkelly09 requested a review from eshaben February 4, 2025 15:29
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben added B1 - Ready to Merge Pull request is ready to be merged and removed B0 - Needs Review Pull request is ready for review labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) B1 - Ready to Merge Pull request is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants