Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Substrate.io Migration] Runtime Upgrades #19

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Conversation

CrackTheCode016
Copy link
Collaborator

The "Runtime Upgrades" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/maintain/runtime-upgrades/

@CrackTheCode016 CrackTheCode016 added B0 - Needs Review Pull request is ready for review and removed In Progress labels Sep 16, 2024
Copy link
Member

@DrW3RK DrW3RK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I go further into reviewing this PR, I would like to understand the scope of this document.

I see that this is under parachain-devs/parachain-maintenance which means the content can be streamlined to just that and the elaboration on forkless runtime upgrades, solo chains etc. which can live in the Polkadot protocol section which consists of the well written content from https://wiki.polkadot.network/docs/learn-runtime-upgrades

We can remove the info section on "Why Forkless" altogether and link to the forkless upgrades section elsewhere in the document when it is ready. wdyt?

@dawnkelly09 dawnkelly09 requested a review from eshaben September 26, 2024 18:06
@dawnkelly09
Copy link
Collaborator

@eshaben take a look at this and let me know what you think. We'll need CSS on admonitions/drop downs at some point

Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what admonition style you're looking for, but the custom ones available are code, function, child, interface - if we don't have what you need, let me know!

@dawnkelly09
Copy link
Collaborator

@eshaben added an intro and took out the drop downs.

@dawnkelly09 dawnkelly09 requested a review from eshaben October 1, 2024 19:42
@dawnkelly09 dawnkelly09 requested a review from eshaben October 3, 2024 19:32
@dawnkelly09 dawnkelly09 requested a review from a team as a code owner October 3, 2024 19:36
Copy link
Collaborator

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM!

If we need to change the scope of this or make modifications so this page better fits in it's final home (considering IA is being reviewed and updated right now), we can do that once we get to a more settled place

Copy link
Collaborator

@0xLucca 0xLucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xLucca 0xLucca merged commit d47d6be into master Oct 9, 2024
@0xLucca 0xLucca deleted the bd-runtime-upgrades branch October 9, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0 - Needs Review Pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants