-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Substrate.io Migration] Runtime Upgrades #19
Conversation
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I go further into reviewing this PR, I would like to understand the scope of this document.
I see that this is under parachain-devs/parachain-maintenance
which means the content can be streamlined to just that and the elaboration on forkless runtime upgrades, solo chains etc. which can live in the Polkadot protocol section which consists of the well written content from https://wiki.polkadot.network/docs/learn-runtime-upgrades
We can remove the info section on "Why Forkless" altogether and link to the forkless upgrades section elsewhere in the document when it is ready. wdyt?
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
.snippets/code/develop/parachain-devs/parachain-maintenance/runtime_version.rs
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
Co-authored-by: 0xLucca <[email protected]> Co-authored-by: Radha <[email protected]>
@eshaben take a look at this and let me know what you think. We'll need CSS on admonitions/drop downs at some point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what admonition style you're looking for, but the custom ones available are code
, function
, child
, interface
- if we don't have what you need, let me know!
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
@eshaben added an intro and took out the drop downs. |
develop/parachain-devs/parachain-maintenance/runtime-upgrades.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Erin Shaben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LGTM!
If we need to change the scope of this or make modifications so this page better fits in it's final home (considering IA is being reviewed and updated right now), we can do that once we get to a more settled place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The "Runtime Upgrades" page was migrated from the existing Substrate.io Tutorial section: https://docs.substrate.io/maintain/runtime-upgrades/