Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added z-index:-10 and settings multiWords: true, onKeyup #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mdipierro
Copy link

Hello polarblau,

I made three changes to jquery.suggest.js:

I added z-index: -10 in the JS so that it works even if there is no CSS to set the z-index: +10 for the input. When I first used the plugin I thought it was broken because it did not work without the CSS.

I added a new option multiWords which defaults to false (existing behavior) but when set to true allows autocompletion of the last word of the text. For example if I type "bla bla bla Py" it will autocomplete Py with Py[thon] and leave "bla bla" unchanged.

I added a new option onKeyup which is called onKeyup.

@mdipierro mdipierro closed this Mar 24, 2014
@mdipierro mdipierro reopened this Mar 24, 2014
@polarblau
Copy link
Owner

Awesome! Thanks a lot.

Would you be possibly able to add some specs for the new behavior (the multiWords option and the onKeyup event)? I’m happy to help you if need be.

@polarblau
Copy link
Owner

And one question: could you explain your use case for embedding the keyup callback? Why not use a regular jQuery callback? Could this be solved by re–triggering the event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants