feat(python): Ensure AWS credential provider sources AWS_PROFILE from environment after deserialization #21121
+11
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended for cloud / remote execution support.
It currently uses the one sourced during local initialization even after being deserialized on a remote machine.
Note that a case that we still don't handle well is if a user's local machine doesn't have permissions to the cloud storage, while the remote machine does. In this case remote execution will also not use a credential provider.
What I think should instead happen is that the
_maybe_init_credential_provider()
credential provider resolution is performed on the remote machine before the query is executed. Doing this is a bit more involved, but I plan to get this working next week.