Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relayminer, Bug] fix: sessiontree logger never initialized #993

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Dec 11, 2024

Summary

Fixes a nil pointer panic in the relayminer; the logger member is never initialized.

Issue

  • N/A

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

(cherry picked from commit 7d48aef23354497be55958ad2f484e1734550249)
@bryanchriswhite bryanchriswhite added bug Something isn't working relayminer Changes related to the Relayminer off-chain Off-chain business logic labels Dec 11, 2024
@bryanchriswhite bryanchriswhite self-assigned this Dec 11, 2024
@bryanchriswhite bryanchriswhite linked an issue Dec 11, 2024 that may be closed by this pull request
4 tasks
@bryanchriswhite bryanchriswhite marked this pull request as ready for review December 11, 2024 21:37
@bryanchriswhite
Copy link
Contributor Author

@red-0ne can you confirm whether this is a duplicate of #1007 and if there's anything that doesn't overlap that we should keep (e.g. perhaps moving the .With() up in scope).

@red-0ne
Copy link
Contributor

red-0ne commented Dec 13, 2024

@bryanchriswhite , Yes it's a duplicate with some minor differences.

The logger's With is something we should keep 👍

pkg/relayer/session/sessiontree.go Outdated Show resolved Hide resolved
pkg/relayer/session/sessiontree.go Show resolved Hide resolved
@bryanchriswhite bryanchriswhite merged commit 91250b3 into main Dec 13, 2024
10 checks passed
bryanchriswhite added a commit that referenced this pull request Dec 13, 2024
* pokt/main:
  [Relayminer, Bug] fix: sessiontree logger never initialized (#993)
  fix: E2E tests - RPC URL path (#1008)
  Updated cheat sheat docs with an example after installation (#1004)
  fix: Nil session tree logger (#1007)
@bryanchriswhite bryanchriswhite deleted the fix/sessiontree branch December 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working off-chain Off-chain business logic relayminer Changes related to the Relayminer
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Off-Chain] ModuleParamsClient & Historical Params
2 participants