fix: avatar selection change event bug causing null ref

poi-vrc · Dec 29, 2024 · 45090c0 · 45090c0
1 parent dd40123
commit 45090c0
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/Editor/UI/Presenters/MainPresenter.cs b/Editor/UI/Presenters/MainPresenter.cs
@@ -143,9 +143,9 @@ private void UpdateView()
                 _view.SelectedAvatarIndex = 0;
             }
 
-            if (oldIndex != _view.SelectedAvatarIndex)
+            if (oldIndex != -1 && oldIndex != _view.SelectedAvatarIndex)
             {
-                _view.RaiseAvatarSelectionPopupChangeEvent();
+                _view.RaiseAvatarSelectionChangeEvent();
             }
 
             _view.ToolVersionText = UpdateChecker.CurrentVersion?.fullString;

diff --git a/Editor/UI/Views/IMainView.cs b/Editor/UI/Views/IMainView.cs
@@ -36,6 +36,7 @@ internal interface IMainView : IEditorView
         event Action<PrefabStage> PrefabStageClosing;
         event Action<PrefabStage> PrefabStageOpened;
         event Action AvatarSelectionPopupChange;
+        event Action AvatarSelectionChange;
 
         string UpdateAvailableFromVersion { get; set; }
         string UpdateAvailableToVersion { get; set; }
@@ -50,6 +51,6 @@ internal interface IMainView : IEditorView
         void ForceUpdateCabinetSubView();
         void StartDressing(GameObject outfitGameObject = null, GameObject avatarGameObject = null);
         void OpenUrl(string url);
-        void RaiseAvatarSelectionPopupChangeEvent();
+        void RaiseAvatarSelectionChangeEvent();
     }
 }
diff --git a/Editor/UI/Views/MainView.cs b/Editor/UI/Views/MainView.cs
@@ -45,6 +45,7 @@ internal class MainView : ElementView, IMainView
         public event Action UpdateAvailableUpdateButtonClick;
         public event Action MouseMove;
         public event Action AvatarSelectionPopupChange;
+        public event Action AvatarSelectionChange;
 
         public int SelectedAvatarIndex { get; set; }
         public List<GameObject> AvailableAvatars { get; set; }
@@ -94,8 +95,8 @@ public MainView()
             UpdateAvailableFromVersion = null;
             UpdateAvailableToVersion = null;
             ShowExitPlayModeHelpbox = false;
-            SelectedAvatarIndex = 0;
-            _lastSelectedAvatarIndex = 0;
+            SelectedAvatarIndex = -1;
+            _lastSelectedAvatarIndex = -1;
             AvailableAvatars = new List<GameObject>();
         }
 
@@ -272,11 +273,11 @@ private void RepaintAvatarSelection()
             _avatarSelectionPopupContainer.Add(_avatarSelectionPopup);
 
             // force update avatar subview if the selected index has changed
-            if (_lastSelectedAvatarIndex != SelectedAvatarIndex)
+            if (_lastSelectedAvatarIndex != -1 && _lastSelectedAvatarIndex != SelectedAvatarIndex)
             {
-                _lastSelectedAvatarIndex = SelectedAvatarIndex;
                 _avatarSubView.RaiseForceUpdateViewEvent();
             }
+            _lastSelectedAvatarIndex = SelectedAvatarIndex;
         }
 
         private void RepaintDebugInfo()
@@ -294,6 +295,6 @@ public override void Repaint()
             RepaintDebugInfo();
         }
 
-        public void RaiseAvatarSelectionPopupChangeEvent() => AvatarSelectionPopupChange?.Invoke();
+        public void RaiseAvatarSelectionChangeEvent() => AvatarSelectionChange?.Invoke();
     }
 }
diff --git a/Editor/UI/Views/OneConfDressSubView.cs b/Editor/UI/Views/OneConfDressSubView.cs
@@ -34,7 +34,7 @@ internal class OneConfDressSubView : ElementView, IOneConfDressSubView, IOneConf
     {
         private static readonly I18nTranslator t = I18n.ToolTranslator;
 
-        public event Action TargetAvatarChange { add => _mainView.AvatarSelectionPopupChange += value; remove => _mainView.AvatarSelectionPopupChange -= value; }
+        public event Action TargetAvatarChange { add => _mainView.AvatarSelectionChange += value; remove => _mainView.AvatarSelectionChange -= value; }
         public event Action TargetWearableChange;
         public event Action AddToCabinetButtonClick;
         public GameObject TargetAvatar { get => _mainView.SelectedAvatarGameObject; }