Skip to content

Commit

Permalink
fix: use signrawtransactionwithwallet (#947)
Browse files Browse the repository at this point in the history
  • Loading branch information
lautarodragan authored Jul 3, 2019
1 parent b07b875 commit 6e32e04
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 12 deletions.
2 changes: 0 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ services:
-rpcuser=bitcoinrpcuser
-rpcpassword=bitcoinrpcpassword
-rpcallowip=::/0
-deprecatedrpc=signrawtransaction

bitcoind-2:
image: ruimarinho/bitcoin-core:0.17.0
Expand All @@ -70,7 +69,6 @@ services:
-rpcuser=bitcoinrpcuser
-rpcpassword=bitcoinrpcpassword
-rpcallowip=::/0
-deprecatedrpc=signrawtransaction

k6:
build:
Expand Down
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"dependencies": {
"@po.et/poet-js": "5.1.17",
"amqplib": "0.5.3",
"bitcoin-core": "2.0.0",
"bitcoin-core": "2.2.0",
"bs58": "4.0.1",
"form-data": "2.3.3",
"ipfs-http-client": "28.1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/BlockchainWriter/Controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export class Controller {
'Got fundedTransaction from Bitcoin Core',
)

const signedTransaction = await bitcoinCore.signRawTransaction(fundedTransaction.hex)
const signedTransaction = await bitcoinCore.signRawTransactionWithWallet(fundedTransaction.hex)

logger.trace(
{
Expand Down
1 change: 1 addition & 0 deletions typings/bitcoin-core.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ declare module 'bitcoin-core' {
fundRawTransaction(hexstring: string, options?: FundRawTransactionOptions): Promise<FundRawTransactionResponse>
setNetworkActive(flag: boolean): Promise<void>
signRawTransaction(hexstring: string): Promise<SignRawTransactionResponse>
signRawTransactionWithWallet(hexstring: string): Promise<SignRawTransactionResponse>
sendRawTransaction(hexstring: string): Promise<string>
estimateSmartFee(blocks: number): Promise<EstimateSmartFeeResponse>
}
Expand Down

0 comments on commit 6e32e04

Please sign in to comment.