Skip to content

Commit

Permalink
fix: updrageded to beta 8
Browse files Browse the repository at this point in the history
  • Loading branch information
leftieFriele committed Nov 12, 2024
1 parent 8e79ba3 commit 2c480cb
Show file tree
Hide file tree
Showing 6 changed files with 27 additions and 23 deletions.
1 change: 1 addition & 0 deletions lib/resolver.content.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export default class PodletClientContentResolver {
error,
);
});
this.#http.metrics.pipe(this.#metrics);
}

get metrics() {
Expand Down
1 change: 1 addition & 0 deletions lib/resolver.fallback.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export default class PodletClientFallbackResolver {
error,
);
});
this.#http.metrics.pipe(this.#metrics);
}

get metrics() {
Expand Down
1 change: 1 addition & 0 deletions lib/resolver.manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ export default class PodletClientManifestResolver {
error,
);
});
this.#http.metrics.pipe(this.#metrics);
}

get metrics() {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"dependencies": {
"@hapi/boom": "10.0.1",
"@metrics/client": "2.5.3",
"@podium/http-client": "1.0.0-beta.5",
"@podium/http-client": "1.0.0-beta.8",
"@podium/schemas": "5.1.0",
"@podium/utils": "5.3.2",
"abslog": "2.4.4",
Expand Down
26 changes: 15 additions & 11 deletions tests/integration.basic.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -394,25 +394,29 @@ tap.test('integration basic - metrics stream objects created', async (t) => {

const metrics = [];
client.metrics.on('data', (metric) => {
if (metric.name !== 'http_client_breaker_events') metrics.push(metric);
if (
metric.name !== 'http_client_breaker_events' &&
metric.name.indexOf('podium_client') !== -1
)
metrics.push(metric);
});
client.metrics.on('end', async () => {
t.equal(metrics.length, 6);
t.equal(metrics[1].name, 'podium_client_resolver_manifest_resolve');
t.equal(metrics[1].type, 5);
t.same(metrics[1].labels[0], {
t.equal(metrics.length, 3);
t.equal(metrics[0].name, 'podium_client_resolver_manifest_resolve');
t.equal(metrics[0].type, 5);
t.same(metrics[0].labels[0], {
name: 'name',
value: 'clientName',
});
t.equal(metrics[3].name, 'podium_client_resolver_fallback_resolve');
t.equal(metrics[3].type, 5);
t.same(metrics[3].labels[0], {
t.equal(metrics[1].name, 'podium_client_resolver_fallback_resolve');
t.equal(metrics[1].type, 5);
t.same(metrics[1].labels[0], {
name: 'name',
value: 'clientName',
});
t.equal(metrics[5].name, 'podium_client_resolver_content_resolve');
t.equal(metrics[5].type, 5);
t.same(metrics[5].labels[0], {
t.equal(metrics[2].name, 'podium_client_resolver_content_resolve');
t.equal(metrics[2].type, 5);
t.same(metrics[2].labels[0], {
name: 'name',
value: 'clientName',
});
Expand Down
19 changes: 8 additions & 11 deletions tests/resolver.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,18 @@ tap.test(
function verify(stream) {
return new Promise((resolve) => {
const metrics = [];
stream.on('data', (metric) => metrics.push(metric));
stream.on('data', (metric) => {
if (metric.name.indexOf('podium') !== -1) {
metrics.push(metric);
}
});
stream.on('end', async () => {
t.equal(metrics.length, 3);

t.equal(metrics[1].name, 'http_client_breaker_events');
t.equal(metrics[1].type, 2);
t.same(metrics[1].labels[0], {
name: 'name',
value: 'success',
});
t.equal(metrics.length, 1);
t.equal(
metrics[2].name,
metrics[0].name,
'podium_client_resolver_manifest_resolve',
);
t.equal(metrics[2].type, 5);
t.equal(metrics[0].type, 5);
resolve();
});
});
Expand Down

0 comments on commit 2c480cb

Please sign in to comment.