Add section 1 rule 6 #1607
Closed
Add section 1 rule 6 #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return { | ||
| "comparison_result": comparison_result, | ||
| "error_msg_list": error_msg_list, | ||
| "has_renewable": sum(renewable_annual_site_energy_use_list) > ZERO.ENERGY, |
There was a problem hiding this comment.
My understanding is the type of renewable_annual_site_energy_use_list is a list of list - Should we use list comprehension or flatten the list to sum up?
There was a problem hiding this comment.
Good point, I will update it.
yunjoonjung-PNNL
approved these changes
Jan 22, 2025
… into RS/WX/update_1_6 # Conflicts: # rct229/rulesets/ashrae9012019/section1/section1rule6.py
…lidation is failing for an unknown reason. Manual review shows no errors.
…ation and pass rule 1-6.
…e comparisons might sometimes fail because "in" means something different for a list than a string. Ruletest 1-8 returns a list that had the correct message, but it was not a string and therefore the comparison was failing.
Ruletest 1-6 update, renumber old 1-6, 1-7
|
Fixed in #1629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is draft implementation.
The rules are renumbered:
Original 1-6 -> 1-7
Original 1-7 -> 1-8
New 1-6 is added: #1570
This PR is putting on hold for review. The schema element: energysource does not have ON_SITE_RENEWABLE enum in the latest RES.