binding/fortran: update python scripts now we always have IO functions #7276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now all f2c/c2f functions are actual C functions (rather than macros), the f08 binding can directly call those functions. This is one step toward MPI ABI since it no longer assume handles are integers. The next step is to adjust handle sizes (e.g. c_Comm) based on whether mpi ABI is enabled.
Now MPI-IO functions are always available -- dummy functions if ROMIO is disabled -- the fortran bindings no longer need the "-no-mpiio" option.
hzhou
force-pushed
the
2501_fortran_io
branch
from
4343557 to
316d1e7
Compare
|
test:mpich/ch3/tcp test:mpich/custom --disable-romio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
the f08 binding can directly call those functions.
This is one step toward MPI ABI since it no longer assume handles are
integers. The next step is to adjust handle sizes (e.g. c_Comm) based on
whether mpi ABI is enabled.
disabled -- the fortran bindings no longer need the "-no-mpiio" option.
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.