fix: issue with translations in the plugin admin sections

pluginpal · Jan 16, 2024 · dee1907 · dee1907
1 parent 9c6e0d8
commit dee1907
Show file tree

Hide file tree

Showing 5 changed files with 69 additions and 45 deletions.
diff --git a/.changeset/wet-bats-battle.md b/.changeset/wet-bats-battle.md
@@ -0,0 +1,8 @@
+---
+"@pluginpal/webtools-addon-redirects": patch
+"@pluginpal/webtools-addon-sitemap": patch
+"@pluginpal/webtools-addon-menus": patch
+"@pluginpal/webtools-core": patch
+---
+
+Fix issue with the admin translations
diff --git a/packages/addons/menus/admin/src/index.tsx → packages/addons/menus/admin/src/index.ts b/packages/addons/menus/admin/src/index.tsx → packages/addons/menus/admin/src/index.ts
@@ -43,17 +43,21 @@ export default {
   },
   async registerTrads({ locales }: { locales: string[] }) {
     const importedTrads = await Promise.all(
-      locales.map((locale: string) => import(
-        /* webpackChunkName: "sitemap-translation-[request]" */ `./translations/${locale}.json`
-      )
-        .then(({ default: data }) => ({
-          data: prefixPluginTranslations(data as Record<string, string>, pluginId),
-          locale,
-        }))
-        .catch(() => ({
-          data: {},
-          locale,
-        }))),
+      locales.map((locale) => {
+        try {
+          // eslint-disable-next-line import/no-dynamic-require, global-require
+          const data = require(`./translations/${locale}.json`) as Record<string, string>;
+          return {
+            data: prefixPluginTranslations(data, pluginId),
+            locale,
+          };
+        } catch {
+          return {
+            data: {},
+            locale,
+          };
+        }
+      }),
     );
 
     return Promise.resolve(importedTrads);

diff --git a/...ages/addons/redirects/admin/src/index.tsx → packages/addons/redirects/admin/src/index.ts b/...ages/addons/redirects/admin/src/index.tsx → packages/addons/redirects/admin/src/index.ts
@@ -42,17 +42,21 @@ export default {
   },
   async registerTrads({ locales }: { locales: string[] }) {
     const importedTrads = await Promise.all(
-      locales.map((locale: string) => import(
-        /* webpackChunkName: "sitemap-translation-[request]" */ `./translations/${locale}.json`
-      )
-        .then(({ default: data }) => ({
-          data: prefixPluginTranslations(data as Record<string, string>, pluginId),
-          locale,
-        }))
-        .catch(() => ({
-          data: {},
-          locale,
-        }))),
+      locales.map((locale) => {
+        try {
+          // eslint-disable-next-line import/no-dynamic-require, global-require
+          const data = require(`./translations/${locale}.json`) as Record<string, string>;
+          return {
+            data: prefixPluginTranslations(data, pluginId),
+            locale,
+          };
+        } catch {
+          return {
+            data: {},
+            locale,
+          };
+        }
+      }),
     );
 
     return Promise.resolve(importedTrads);

diff --git a/packages/addons/sitemap/admin/src/index.tsx → packages/addons/sitemap/admin/src/index.ts b/packages/addons/sitemap/admin/src/index.tsx → packages/addons/sitemap/admin/src/index.ts
@@ -42,17 +42,21 @@ export default {
   },
   async registerTrads({ locales }: { locales: string[] }) {
     const importedTrads = await Promise.all(
-      locales.map((locale: string) => import(
-        /* webpackChunkName: "sitemap-translation-[request]" */ `./translations/${locale}.json`
-      )
-        .then(({ default: data }) => ({
-          data: prefixPluginTranslations(data as Record<string, string>, pluginId),
-          locale,
-        }))
-        .catch(() => ({
-          data: {},
-          locale,
-        }))),
+      locales.map((locale) => {
+        try {
+          // eslint-disable-next-line import/no-dynamic-require, global-require
+          const data = require(`./translations/${locale}.json`) as Record<string, string>;
+          return {
+            data: prefixPluginTranslations(data, pluginId),
+            locale,
+          };
+        } catch {
+          return {
+            data: {},
+            locale,
+          };
+        }
+      }),
     );
 
     return Promise.resolve(importedTrads);

diff --git a/packages/core/admin/index.ts b/packages/core/admin/index.ts
@@ -124,19 +124,23 @@ export default {
       });
     }
   },
-  async registerTrads({ locales }) {
+  async registerTrads({ locales }: { locales: string[] }) {
     const importedTrads = await Promise.all(
-      locales.map((locale: string) => import(
-        /* webpackChunkName: "webtools-translation-[request]" */ `./translations/${locale}.json`
-      )
-        .then(({ default: data }) => ({
-          data: prefixPluginTranslations(data, pluginId),
-          locale,
-        }))
-        .catch(() => ({
-          data: {},
-          locale,
-        }))),
+      locales.map((locale) => {
+        try {
+          // eslint-disable-next-line import/no-dynamic-require, global-require
+          const data = require(`./translations/${locale}.json`);
+          return {
+            data: prefixPluginTranslations(data, pluginId),
+            locale,
+          };
+        } catch {
+          return {
+            data: {},
+            locale,
+          };
+        }
+      }),
     );
 
     return Promise.resolve(importedTrads);