-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul contributing documentation for Plone 6 #539
Conversation
@stevepiercy thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
I have no clue as to why Jenkins fails for Plone 6.0/Python 3.11 but not for Plone 6.0/Python 3.8. Help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate your overhaul. Just minor suggestions to content that was already there before this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Minor things see comments.
@jenkins-plone-org please run jobs |
Changes made, and I excluded GNU make as a requirement here since this project uses tox instead. It would be nice to use one of make or tox for all of Plone, don't you think? |
Yes, a switch to |
See https://community.plone.org/t/tools-for-development-gnu-make-tox-or/19708 |
Now that we have Plone core contributing documentation, I've simplified and modernized the contributing documentation.
See plone/documentation#1278.
After merging, then merge plone/documentation#1684.