Add tests for minimum free disk space check #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandakovMM
requested changes
Feb 12, 2024
| "/usr": {"source": "/dev/sda1", "target": "/", "avail": req_sum}, | ||
| "/var": {"source": "/dev/sdb1", "target": "/var", "avail": self._requirements["/var"]}, | ||
| } | ||
| with mock.patch( |
There was a problem hiding this comment.
We are going to mock all subprocess.run function calls here, this could cause issues when we add more function calls within check_min_free_disk_space.
| @@ -158,6 +158,60 @@ class MinFreeDiskSpaceViolation(typing.NamedTuple): | |||
| """Paths belonging to this device.""" | |||
|
|
|||
|
|
|||
| def check_min_free_disk_space(requirements: typing.Dict[str, int]) -> typing.List[MinFreeDiskSpaceViolation]: | |||
There was a problem hiding this comment.
I believe we could split this function into two parts - retrieving data from the findmnt utility and check restrictions. So in tests we could just mock the retriving data function itself, but not the subprocess.run.
| from pleskdistup.common import log | ||
|
|
||
|
|
||
| def init_logger(): |
There was a problem hiding this comment.
We could move the change into separated commit. Something like: "Enable logging for tests"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.