Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] JVM and Android Coverage #571

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KetanReddy
Copy link
Member

Collect coverage for JVM and Android test targets

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major
  • N/A

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

TODO:

  • Update getting started docs for JDK 17 requirement
  • Collect coverage for //jvm/hermes/.. targets

@KetanReddy KetanReddy added the skip-release Preserve the current version when merged label Jan 10, 2025
@KetanReddy KetanReddy self-assigned this Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (cb3ea0c) to head (f5182bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   89.76%   89.75%   -0.01%     
==========================================
  Files         331      331              
  Lines       19836    19836              
  Branches     1949     1949              
==========================================
- Hits        17805    17804       -1     
- Misses       2017     2018       +1     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy
Copy link
Member Author

So it looks like enabling ABI Jars is required to make coverage work for targets that use inline functions (which is a known issue in rules kotlin) but for some reason that causes the jvm core and hermes tests to fail. It seems like the kt_abi_plugin_incompatible tag isn't being propagated correctly or it needs to be specified on the source packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant