Scroll depth: update site.scroll_depth_visible_at in ingestion
#5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
genserver-update-scroll-depth-visibility
branch
from
9bce221 to
37eae52
Compare
zoldar
reviewed
Jan 30, 2025
zoldar
reviewed
Jan 30, 2025
RobertJoonas
approved these changes
Feb 3, 2025
| use Plausible.DataCase | ||
| use Plausible.Teams.Test | ||
|
|
||
| test "mark_scroll_depth_visible" do |
There was a problem hiding this comment.
This test can never fail. We should assert on the return value of TestUtils.eventually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decide what metrics to show dynamically based on whether site has sent us scroll depth data.
Previously, this data was queried dynamically from ClickHouse on page loads, but this approach adds 50-200ms to every page load until a site has sent us scroll depth data.
Instead, we now update
site.scroll_depth_visible_atin ingestion. To limit impact on ingestion:scroll_depth_visible_atis now cached along with other ingestion site data.I'm curious whether I'm taking a sane approach with the GenServer here. cc @zoldar for feedback on that front.