APIv2: validate combining event-only metrics with session-only dimensions #5015
+83
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macobo
force-pushed
the
fix-event-metrics-session-dimensions-validation
branch
from
5e02ad7 to
847343f
Compare
…nsions
Currently the following query results in a 500:
```json
{
"site_id": "plausible.io",
"metrics": ["visitors", "events", "pageviews"],
"dimensions": ["visit:exit_page"],
"date_range": "7d"
}
```
This adds proper validation for that case that was previously missing.
macobo
force-pushed
the
fix-event-metrics-session-dimensions-validation
branch
from
847343f to
fe75f1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the following query results in a 500:
{ "site_id": "plausible.io", "metrics": ["visitors", "events", "pageviews"], "dimensions": ["visit:exit_page"], "date_range": "7d" }This adds proper validation for that case that was previously missing.
In the future we might be able to remove some of these validations by selecting the appropriate value(s) from sessions table.
Basecamp ref: https://3.basecamp.com/5308029/buckets/39750953/card_tables/cards/8251923578