Refactor including imports in stats queries #5011
Open
+545
−489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR prepares the codebase with a refactor in order to make
SiteImport
structs available in stats queries. The plan is to useSiteImport
s to decide whether or notscroll_depth
gets included from imported data or not. This information will be included inmeta.metric_warnings
.This PR also aims to move the logic of responding with imported flags (such as
imports_included
andskip_imported_reason
) into a single place -QueryResult
. The values for these fields depend on bothquery
andcomparison_query
which this PR makes available inQueryResult
.Tests
Changelog
Documentation
Dark mode