Proposal: Remove unique users from dashboard when filtering by goal
#4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current dashboard, "Unique users" denotes the number of users who match the filter except in one case: When filtering by a goal. In that case this number means number of users without the goal filter.
This caused confusion in another review and I find this confusing. I confirmed this with @metmarkosaric that this might be a historical quirk that's safe to remove.
This can cause extra confusion since "excluding" goals would not behave the same.
Sending this to @ukutaht since he has historical context. I'm not confident in this change and the goal is to spark a discussion.
Before:
After:
