Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition loading breakdown modals #4950

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Fix race condition loading breakdown modals #4950

merged 1 commit into from
Jan 8, 2025

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jan 8, 2025

Locally I ran into a FE race condition bug on loading breakdown modal data due to how items and response.meta was handled. This fixes that by handling meta not being loaded yet gracefully.

Locally I ran into a FE race condition bug on loading breakdown modal data
due to how items and `response.meta` was handled. This fixes that by
handling meta not being loaded yet gracefully.
@macobo macobo marked this pull request as ready for review January 8, 2025 12:07
@macobo macobo requested a review from a team January 8, 2025 12:07
Copy link

github-actions bot commented Jan 8, 2025

Preview environment👷🏼‍♀️🏗️
PR-4950

Copy link
Contributor

@RobertJoonas RobertJoonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! 👍

@macobo macobo added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 36fe62e Jan 8, 2025
9 checks passed
@RobertJoonas RobertJoonas deleted the fix-meta-null branch January 8, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants