Teams setup schema #4944
Merged
Teams setup schema #4944
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
force-pushed
the
teams-setup-schema
branch
from
eebd50a to
10ebb31
Compare
zoldar
approved these changes
Jan 7, 2025
ukutaht
reviewed
Jan 7, 2025
| @@ -25,6 +25,9 @@ defmodule Plausible.Teams.Team do | |||
| field :accept_traffic_until, :date | |||
| field :allow_next_upgrade_override, :boolean, default: false | |||
|
|
|||
| field :setup_complete, :boolean, default: false | |||
There was a problem hiding this comment.
Question: what's the purpose of the boolean if there's also a timestamp? Would the presence of the timestamp, or lack thereof, not provide the same information as the boolean?
There was a problem hiding this comment.
Boolean is straightforward to match, no dealing with null tri-state. Timestamp is just for troubleshooting/auditing purposes for now and might go away in the future.
There was a problem hiding this comment.
Another way of looking at it: the app never cares about the actual date specifics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #4943 is merged