Install nodejs specced in tool-versions in Dockerfile #4942
+25
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RobertJoonas
force-pushed
the
proper-fix-build-images
branch
from
13571c7 to
23baf4b
Compare
apata
reviewed
Jan 7, 2025
Comment on lines
+27
to
+30
| && wget -qO- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash \ | ||
| && export NVM_DIR="$HOME/.nvm" \ | ||
| && [ -s "$NVM_DIR/nvm.sh" ] && . "$NVM_DIR/nvm.sh" \ | ||
| && nvm install ${NODE_VERSION} |
There was a problem hiding this comment.
Why not skip the middleman and wget the version we know we want directly from https://nodejs.org/dist/?
There was a problem hiding this comment.
The problem is that all those distributions are incompatible with Alpine Linux as it's using musl libc. Musl-compatible builds have been requested before, but it looks like so far there are only unofficial ones available.
|
Closing in favour of #4945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #4933.
We'll use
nvmto install the same version of nodejs as specified in the.tool-versionsfile. Also, rather than always installing the latest version of NPM (as it was before #4933), nvm will install the one that's bundled with the specific nodejs version (the same happens viaasdf install).