Fix membership role action and checks under Site Settings > People #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zoldar
commented
Dec 16, 2024
| @@ -142,7 +142,7 @@ | |||
| </p> | |||
| </div> | |||
|
|
|||
| <%= if membership.role == :admin do %> | |||
| <%= if membership.role == "admin" do %> | |||
There was a problem hiding this comment.
Currently membership.role type here is inconsistent - for owner, it's an atom, for the rest, it's a string. We'll correct that on subsequent rewrite.
aerosol
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This logic will be soon revised (and replaced) once we commence with implementing teams support.
This is a fix for a regression where Admin role update under Site Settings > People is failing due to wrong mapping.