Switch reads to Teams schemas across the rest of the app #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to translate `admin`<->`editor` here, the redundancy is inlined wherever the plug is initialized.
By making artificial site membership struct, when reading data off team membership schema.
This reverts commit 0e45f8c.
|
zoldar
force-pushed
the
team-journey-9
branch
from
2e4823e to
d95f90a
Compare
zoldar
changed the title
zoldar
force-pushed
the
team-journey-9
branch
from
d95f90a to
2e4823e
Compare
aerosol
approved these changes
Dec 2, 2024
zoldar
added a commit
that referenced
this pull request
Dec 2, 2024
…)" This reverts commit b86c2e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR switches majority of reads related to membership and subscription state to use new team schemas. All the leftovers will be switched with the final change - switching all the writes to use new schema exclusively as well.
Notable changes:
AuthorizeSiteAccessis now populatingcurrent_user_rolewith team schema roles. The change is accounted for by always considering:editorrole side by side with:admin