Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update acquisition channel UDF to prioritize display over paid search #4818

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Update acquisition channel UDF to prioritize display over paid search #4818

merged 3 commits into from
Nov 14, 2024

Conversation

ukutaht
Copy link
Contributor

@ukutaht ukutaht commented Nov 13, 2024

Changes

Ref: https://3.basecamp.com/5308029/buckets/39036182/card_tables/cards/8022487952

Tests

  • Automated tests have been added

macobo
macobo approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

I'll get this live, but push a few changes to ensure it works as expected + add test in test/plausible/ingestion/acquisition_test.exs

@macobo
Remove migration
35b747c 
Will run this manually together with a backfill, self-hosted will get this for free.
@macobo
Add test
db11d2a
@macobo macobo added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit daa42cb Nov 14, 2024
10 checks passed
@macobo macobo deleted the fix-display-channel branch November 14, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ukutaht @macobo