Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channels: Read from new column, don't write #4800

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Nov 11, 2024

Changes

Follow-up to #4798

Once this change is in, we'll read from the new acquisition_channel column.

@macobo macobo changed the base branch from master to acquisition-channels-migration November 11, 2024 10:25
@macobo macobo requested a review from ukutaht November 11, 2024 10:26
@macobo macobo force-pushed the acquisition-channels-writes-and-reads branch from c4e2a88 to f3cdd70 Compare November 11, 2024 10:27
Copy link
Contributor

@ukutaht ukutaht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@macobo macobo force-pushed the acquisition-channels-migration branch from 9bf5fa9 to bc47c84 Compare November 11, 2024 11:33
@macobo macobo force-pushed the acquisition-channels-writes-and-reads branch 2 times, most recently from 91473f2 to aea0033 Compare November 11, 2024 12:03
@macobo macobo force-pushed the acquisition-channels-migration branch 2 times, most recently from 2003b68 to bd3a427 Compare November 11, 2024 20:56
@macobo macobo force-pushed the acquisition-channels-writes-and-reads branch from aea0033 to f98a666 Compare November 12, 2024 06:49
@macobo macobo changed the base branch from acquisition-channels-migration to master November 12, 2024 07:47
@macobo macobo force-pushed the acquisition-channels-writes-and-reads branch from f98a666 to 9b48035 Compare November 12, 2024 07:47
@macobo macobo added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit 3809ebf Nov 12, 2024
10 checks passed
@macobo macobo deleted the acquisition-channels-writes-and-reads branch November 12, 2024 12:36
apata pushed a commit that referenced this pull request Nov 14, 2024
* Read and write channels from `acquisition_channel` column

* Update csv tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants