Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish moving /sites LV reads to team schemas behind FF #4777

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

zoldar
Copy link
Contributor

@zoldar zoldar commented Nov 5, 2024

.

@zoldar zoldar force-pushed the team-sync-journey branch from 80d40a1 to 27697fe Compare November 6, 2024 10:58
@aerosol aerosol force-pushed the team-sync-journey branch 3 times, most recently from 5707728 to 15a35c7 Compare November 6, 2024 12:54
@aerosol aerosol changed the title Team sync journey Finish moving /sites LV reads to team schemas (behind a FF still) Nov 6, 2024
@aerosol aerosol changed the title Finish moving /sites LV reads to team schemas (behind a FF still) Finish moving /sites LV reads to team schemas behind FF Nov 6, 2024
@zoldar zoldar marked this pull request as ready for review November 6, 2024 12:59
@zoldar zoldar requested a review from aerosol November 6, 2024 13:00
@aerosol aerosol added this pull request to the merge queue Nov 6, 2024
@aerosol aerosol removed this pull request from the merge queue due to a manual request Nov 6, 2024
@aerosol aerosol enabled auto-merge November 6, 2024 13:04
@aerosol aerosol disabled auto-merge November 6, 2024 13:04
@aerosol aerosol added the preview label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

Preview environment👷🏼‍♀️🏗️
PR-4777

@zoldar zoldar added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 342c3e5 Nov 6, 2024
12 checks passed
@aerosol aerosol deleted the team-sync-journey branch November 6, 2024 13:28
apata pushed a commit that referenced this pull request Nov 14, 2024
* Implement user owning existing and pending sites check for teams

* Add predicate checking whether user has any existin or pending sites via teams

* Check need to upgrade for sites list via teams when FF is up

* Backfill teams for users on trial without a team

* Create team for users who register with trial started

* Replicate trial start logic on user create in team factories

* Make `ensure_can_take_ownership` in sites LV work via teams too

* Dispatch feature access check from `/sites` to Teams-schema reads

---------

Co-authored-by: Adam Rutkowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants