-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish moving /sites LV reads to team schemas behind FF #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
force-pushed
the
team-sync-journey
branch
from
November 6, 2024 10:58
80d40a1
to
27697fe
Compare
aerosol
force-pushed
the
team-sync-journey
branch
3 times, most recently
from
November 6, 2024 12:54
5707728
to
15a35c7
Compare
aerosol
changed the title
Team sync journey
Finish moving /sites LV reads to team schemas (behind a FF still)
Nov 6, 2024
aerosol
changed the title
Finish moving /sites LV reads to team schemas (behind a FF still)
Finish moving /sites LV reads to team schemas behind FF
Nov 6, 2024
aerosol
approved these changes
Nov 6, 2024
aerosol
force-pushed
the
team-sync-journey
branch
from
November 6, 2024 13:02
15a35c7
to
d01df73
Compare
|
apata
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Implement user owning existing and pending sites check for teams * Add predicate checking whether user has any existin or pending sites via teams * Check need to upgrade for sites list via teams when FF is up * Backfill teams for users on trial without a team * Create team for users who register with trial started * Replicate trial start logic on user create in team factories * Make `ensure_can_take_ownership` in sites LV work via teams too * Dispatch feature access check from `/sites` to Teams-schema reads --------- Co-authored-by: Adam Rutkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.