Set root domain (none) for ingests without hostname
#4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
commented
Oct 15, 2024
lib/plausible/ingestion/event.ex
Outdated
| @@ -541,6 +541,7 @@ defmodule Plausible.Ingestion.Event do | |||
| end | |||
| end | |||
|
|
|||
| defp get_root_domain("(none)"), do: "(none)" | |||
| defp get_root_domain(nil), do: "(none)" | |||
There was a problem hiding this comment.
🤔 at this point hostname shouldn't ever be nil - rejected at the requested creation level at best
|
macobo
reviewed
Oct 15, 2024
ukutaht
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is not a bug, but more of a micro-optimization. If the hostname is known to be
(none), there's no need try and compute root domain.👀 At the same, it looks like ingestion had a dead clause trying to match
nilhostname.Plausible.Ingestion.Requestshould reject such cases before they reachPlausible.Ingestion.Eventprocessing.Ref https://3.basecamp.com/5308029/buckets/26383192/card_tables/cards/7916301991
Tests
Changelog
Documentation
Dark mode