Reduce Phoenix.HTML usage #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ruslandoga
reviewed
Oct 14, 2024
apata
reviewed
Oct 14, 2024
apata
reviewed
Oct 14, 2024
apata
reviewed
Oct 14, 2024
lib/plausible_web/templates/error/server_error_report_thanks.html.eex
Outdated
Show resolved
Hide resolved
apata
approved these changes
Oct 14, 2024
ruslandoga
reviewed
Oct 16, 2024
| <br /><br /> Do check out your | ||
| <.unstyled_link href={"#{plausible_url()}/#{URI.encode_www_form(@site.domain)}"}> | ||
| easy to use, fast-loading and privacy-friendly dashboard | ||
| </.unstyled_link>. <br /><br /> Something looks off? Take a look at our |
There was a problem hiding this comment.
This added newline before the dot seems to translate to whitespace in the rendered HTML
Note how there is no space before the dot and after the first link to dummy.site because it's on the same line.
There was a problem hiding this comment.
An easy workaround is to move the dot inside the link. I'll open a PR.
ruslandoga
pushed a commit
that referenced
this pull request
Jan 6, 2025
* Turn .eex templates into .heex * Add new compile-time presets to `PlausibleWeb` * Fix remaining templates * Update static components * Update live components * Update live views * Update rest of the owl * Update mjml template * Format * Format * Revert MJML stuff, it's coupled with EEx * yawn at test * Get rid of `FormHelpers` module * Ensure YOU label shows up first on IP rules list * Update lib/plausible_web/templates/email/welcome_email.html.heex Co-authored-by: Artur Pata <[email protected]> * Fix create site email link * Fix server error markup (and turn thanks into heex) * Format --------- Co-authored-by: Artur Pata <[email protected]>
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR almost completely removes
Phoenix.HTMLin favor of https://hexdocs.pm/phoenix/components.html#heexNot all occurrences were removable at this time (due to external dependencies and such).
However, all the templates were changed from EEx to HEEx and separate compile-time usage variants were introduced via
use PlausibleWeb, ....Basically there should be no eex tags anymore (such as
<%= form_for ...,<%= link ...etc.) and imports should be simpler to reason about.There's some more work pending to organize the components further, but will be much clearer if done separately.
Of course due to volume of changes and e2e testing limitations, it's possible that some view will turn out scrambled or slightly worse than before... I'm hoping to address those issues on case by case basis.
Tests
Changelog
Documentation
Dark mode