Skip Browserless checks in CE

[ruslandoga]

Changes

Attempt at skipping Browserless checks in CE: #4459 (comment)

Tests

• Automated tests have been added

Changelog

• Entry has been added to changelog
• This PR does not make a user-facing change

Documentation

• Docs have been updated
• This change does not need a documentation update

Dark mode

• The UI has been tested both in dark and light mode
• This PR does not change the UI

[aerosol]

without Checks.Installation, verification won't ever succeed so in that sense this is equivalent to querying a non-existing browserless endpoint.

[ruslandoga]

Is there a way around it? I assumed the verification succeeds after all (or a subset of?) defined checks pass.

[aerosol]

sort of - but plausible_installed? is crucial (and even then - it's not binary, if you skim through the diagnostics module), which comes from the browserless check. Take a look at Plausible.Verification.Diagnostics it's where the decision about user-facing result is made.

Feels also pointless to show verification success to the user if you don't run verification.

We could consider disabling it altogether again, by removing "live "/:website/verification", Verification, :verification, as: :site" route in CE and following up on the consequences. PlausibleWeb.Flows comes to mind as the next thing to deal with...