Breakdown modal search shortcut #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertJoonas
force-pushed
the
breakdown-modal-search-shortcut
branch
from
48677ab to
fe60a5a
Compare
|
RobertJoonas
force-pushed
the
breakdown-modal-search-shortcut
branch
from
d464f3e to
abfa8bc
Compare
apata
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the ability to focus the search input by pressing the
/key in breakdown modals.Also stops rendering the search input box in screen sizes modal (currently on master it's rendered but not functional). It's not needed since the list will never have more than 5 entries.
Tests
Changelog
Documentation
Dark mode