Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter modal fixes #4553

Merged
merged 7 commits into from
Sep 9, 2024
Merged

Filter modal fixes #4553

merged 7 commits into from
Sep 9, 2024

Conversation

RobertJoonas
Copy link
Contributor

@RobertJoonas RobertJoonas commented Sep 9, 2024

Changes

  • Display a loading spinner in the combobox when fetching suggestions for is and is_not filter operators.
  • Extract lastLoadTimestamp from QueryContext into a new, separate context. This is currently causing unnecessary re-renders of any components depending on the queryContext. For instance, when keeping the combobox open, new options are fetched again every 30 seconds.
  • Always consider contains and not_contains as freeChoice filter operators. Currently, the condition on which we consider a filter to be freeChoice is whether the filter key is one of ['screen', 'country', 'region', 'city']. This is wrong because these filters are simply the ones that do not support contains. It has nothing to do with being able to select a custom value to filter by.
  • Fix does_not_contain not being a freeChoice operator in custom property filter modal.

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • This PR does not change the UI

Copy link

github-actions bot commented Sep 9, 2024

Preview environment👷🏼‍♀️🏗️
PR-4553

@RobertJoonas RobertJoonas requested a review from apata September 9, 2024 08:19
@RobertJoonas RobertJoonas merged commit e6993b1 into master Sep 9, 2024
10 checks passed
@RobertJoonas RobertJoonas deleted the filter-modal-fixes branch September 9, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants