Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
is
andis_not
filter operators.contains
andnot_contains
asfreeChoice
filter operators. Currently, the condition on which we consider a filter to be freeChoice is whether the filter key is one of['screen', 'country', 'region', 'city']
. This is wrong because these filters are simply the ones that do not support contains. It has nothing to do with being able to select a custom value to filter by.does_not_contain
not being afreeChoice
operator in custom property filter modal.Tests
Changelog
Documentation
Dark mode