Remove support for legacy user sessions #4540
Conversation
zoldar
force-pushed
the
remove-legacy-user-sessions-support
branch
2 times, most recently
from
f07bb80 to
1281509
Compare
| def revoke_all_user_sessions(user) do | ||
| {_count, tokens} = | ||
| Repo.delete_all( | ||
| from us in Auth.UserSession, where: us.user_id == ^user.id, select: us.token |
There was a problem hiding this comment.
select is probably unnecessary here?
There was a problem hiding this comment.
select here makes the DELETE query return tokens without selecting them separately - they are then iterated over to broadcast "disconnect LV" message.
| ) | ||
|
|
||
| Enum.each(tokens, fn token -> | ||
| PlausibleWeb.Endpoint.broadcast(live_socket_id(token), "disconnect", %{}) |
There was a problem hiding this comment.
nice! awaiting empd integration 🤘 is this a built-in message that's handled elsewhere?
There was a problem hiding this comment.
|
|
The change got reverted. We are going to address this separately together with a proper server error response handling on FE side. |
This reverts commit 77d1a10.
zoldar
force-pushed
the
remove-legacy-user-sessions-support
branch
from
77d1a10 to
c7bb860
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Changes
This PR removes support for legacy sessions entirely. They are treated the same as "no valid token" case.
Additionally, on password reset, all user's sessions are deleted and their LV sockets are disconnected (note: this has limited effect when the pubsub is not connected between the nodes in multi-node scenario).
Tests