Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported disabled graph notice #4522

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

RobertJoonas
Copy link
Contributor

@RobertJoonas RobertJoonas commented Sep 3, 2024

Changes

This PR is to be merged into #4504

  • Return a warning in Stats API timeseries when interval is too short for imported data
  • Display a warning bubble on the dashboard when imported data is excluded from the graph due to interval length

image

This PR also stops returning the imports_exist and includes_imported fields from the main_graph action, as they're unused.

Tests

  • Automated tests have been added

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode

Copy link

github-actions bot commented Sep 3, 2024

Preview environment👷🏼‍♀️🏗️
PR-4522

@RobertJoonas RobertJoonas requested a review from macobo September 3, 2024 16:09
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits

lib/plausible/stats/timeseries.ex Outdated Show resolved Hide resolved
lib/plausible/stats/timeseries.ex Outdated Show resolved Hide resolved
@RobertJoonas RobertJoonas merged commit ab23bc6 into imports-time-hour Sep 4, 2024
10 checks passed
@RobertJoonas RobertJoonas deleted the imported-disabled-graph-notice branch September 4, 2024 07:27
macobo added a commit that referenced this pull request Sep 4, 2024
* Dont include imports for time:hour and time:minute dimensions

Also include more information about import warnings in query results

* Update lib/plausible/stats/query_result.ex

Co-authored-by: RobertJoonas <[email protected]>

* Revert patch

* Imported disabled graph notice (#4522)

* add explicit skip_imported_reason for unsupported interval

* stop returning information about imports from main_graph

* return warning about interval in Stats API Timeseries

* display warning bubble about interval too short for imported data

* update changelog

* improve styling of the exclamation circle icon

* return tuple from timeseries instead of map

* rename variable

* Update CHANGELOG.md

---------

Co-authored-by: RobertJoonas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants