Do not try querying imported data for unsupported props #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
force-pushed
the
fix-ignore-unsupported-internal-keys-in-imported-queries
branch
2 times, most recently
from
b67dd83 to
9442a04
Compare
aerosol
approved these changes
Aug 29, 2024
test/plausible_web/controllers/api/stats_controller/custom_prop_breakdown_test.exs
Outdated
Show resolved
Hide resolved
test/plausible_web/controllers/api/stats_controller/custom_prop_breakdown_test.exs
Outdated
Show resolved
Hide resolved
test/plausible_web/controllers/api/stats_controller/custom_prop_breakdown_test.exs
Outdated
Show resolved
Hide resolved
macobo
reviewed
Aug 30, 2024
test/plausible_web/controllers/api/stats_controller/custom_prop_breakdown_test.exs
Show resolved
Hide resolved
zoldar
force-pushed
the
fix-ignore-unsupported-internal-keys-in-imported-queries
branch
from
ea4fbfb to
7820df9
Compare
zoldar
deleted the
fix-ignore-unsupported-internal-keys-in-imported-queries
branch
ruslandoga
pushed a commit
that referenced
this pull request
Sep 2, 2024
* Do not try querying imported data for unsupported props * Remove unnecessary `unquote`s Co-authored-by: hq1 <[email protected]> * Add respective regression test to APIv2 tests --------- Co-authored-by: hq1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses a problem of a property not (currently) supported for imported data being queried for in imported logic, resulting in a crash.
Tests